Skip to content

Remove redundant parameter from previous_migration function #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

andrew-farries
Copy link
Collaborator

Remove the includeInferred parameter from the previous_migration SQL function as it was set to true at all call sites.

Part of #872

@github-actions github-actions bot temporarily deployed to Docs Preview June 17, 2025 07:32 Inactive
@andrew-farries andrew-farries changed the title Remove redundatnt parameter from previous_migration function Remove redundant parameter from previous_migration function Jun 17, 2025
@andrew-farries andrew-farries marked this pull request as ready for review June 17, 2025 07:35
@andrew-farries andrew-farries requested a review from kvch June 17, 2025 07:35
Remove the `includeInferred` parameter from the `previous_migration`
function as it is always set to `true` in all calls.
Remove `includeInferred` parameter from all call sites.
@andrew-farries andrew-farries force-pushed the remove-param-from-previous-migration-function branch from bdfcf1c to 2b70228 Compare June 17, 2025 11:38
@github-actions github-actions bot temporarily deployed to Docs Preview June 17, 2025 11:38 Inactive
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgroll/pkg/roll 79.87% (ø)
github.com/xataio/pgroll/pkg/state 61.63% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgroll/pkg/roll/execute.go 79.64% (ø) 167 133 34
github.com/xataio/pgroll/pkg/state/state.go 53.04% (ø) 181 96 85

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@andrew-farries andrew-farries merged commit 716f47f into main Jun 17, 2025
30 checks passed
@andrew-farries andrew-farries deleted the remove-param-from-previous-migration-function branch June 17, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants