Skip to content

modules: Add Kconfigs for bootloader requests #93669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

modules: Add Kconfigs for bootloader requests #93669

wants to merge 1 commit into from
+26 −0

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented Jul 24, 2025

Add Kconfig options for bootloader requests module.

@tomchy tomchy force-pushed the feature/zephyr/NCSDK-NONE_boot_requests branch from 04fb1f6 to c3412ef Compare July 24, 2025 12:53
msalau
msalau reviewed Jul 24, 2025
View reviewed changes
modules/Kconfig.mcuboot Outdated
zephyr,retention driver as the memory area to store and read from the
bootloader requests.
The built-in prefix property should be used to indicate the request
structure version to ensure compatibility betwee the bootloader and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/betwee/between/

@tomchy tomchy force-pushed the feature/zephyr/NCSDK-NONE_boot_requests branch from c3412ef to f0fe3aa Compare July 24, 2025 13:27
@tomchy tomchy requested a review from msalau July 24, 2025 13:27
nordicjm
nordicjm reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation is needed on what this does because as a maintainer on 3 things touched here, I have absolutely no clue what any of this is meant to do, preferably as an RFC opened under issues

@tomchy
Copy link
Contributor Author

tomchy commented Jul 24, 2025

documentation is needed on what this does because as a maintainer on 3 things touched here, I have absolutely no clue what any of this is meant to do, preferably as an RFC opened under issues

I'd love to touch a single thing, if possible. The thing is that both the main CMake as well as the main Kconfig file is redirected from the mcuboot project into zephyr project, making it impossible to enclose everything inside the MCUboot repo.

To my understating of the module structure - this should be documented inside the Zephyr's port of MCUboot page. Could you point me to this file?

The reasoning behind this change is expressed in the MCUboot PR, but sure, I can copy it as many times as you need.

@tomchy
modules: Add Kconfigs for bootloader requests
3b9fe20 
Add Kconfig options for bootloader requests module.

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
@tomchy tomchy force-pushed the feature/zephyr/NCSDK-NONE_boot_requests branch from f0fe3aa to 3b9fe20 Compare July 25, 2025 12:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm left review comments

@msalau msalau Awaiting requested review from msalau

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomchy @msalau @nordicjm