Skip to content

Update maxQueuingCompounded in BulkheadSemaphoreFactory #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

Update maxQueuingCompounded in BulkheadSemaphoreFactory #2638

merged 3 commits into from
Jun 10, 2025

Conversation

ahusseini
Copy link
Contributor

Pull Request

The issue or feature being addressed

Fixes #2637, caused by overflow in BulkheadSemaphoreFactory.

Details on the issue fix or feature implementation

Set compound math to long before evaluating Min with int.MaxValue.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@ahusseini ahusseini changed the title Update maxQueuingCompounded Update maxQueuingCompounded in BulkheadSemaphoreFactory Jun 10, 2025
@ahusseini
Copy link
Contributor Author

@dotnet-policy-service agree

@martincostello
Copy link
Member

Thanks for the PR - could you add a test for this please that validates the exception is no longer thrown?

@ahusseini
Copy link
Contributor Author

@martincostello added unit tests

martincostello
martincostello approved these changes Jun 10, 2025
View reviewed changes
@martincostello martincostello added this to the v8.6.1 milestone Jun 10, 2025
@ahusseini @martincostello
Update src/Polly/Bulkhead/BulkheadSemaphoreFactory.cs
b246dfe 
Co-authored-by: Martin Costello <martin@martincostello.com>
@codecov Codecov
Copy link

codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (2f078f9) to head (b246dfe).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7329     7329           
  Branches     1013     1013           
=======================================
  Hits         7053     7053           
  Misses        222      222           
  Partials       54       54
Flag Coverage Δ
linux 96.23% <100.00%> (ø)
macos 96.23% <100.00%> (ø)
windows 96.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) June 10, 2025 22:24
@martincostello martincostello merged commit bbe8807 into App-vNext:main Jun 10, 2025
26 checks passed
@martincostello
Copy link
Member

Thanks!

This was referenced Jul 22, 2025
Closed
Closed
Closed
Closed
Merged
Merged
Closed
This was referenced Jul 29, 2025
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 26, 2025
Closed
Open
Merged
Open
Closed
@dependabot dependabot bot mentioned this pull request Sep 2, 2025
Closed
peggy-quartech pushed a commit to bcgov/PSSG-SPDBT that referenced this pull request Sep 4, 2025
@dependabot
Bump Polly from 8.5.2 to 8.6.3 (#3024)
4b086ab 
Updated [Polly](https://github.com/App-vNext/Polly) from 8.5.2 to 8.6.3.

<details>
<summary>Release notes</summary>

_Sourced from [Polly's
releases](https://github.com/App-vNext/Polly/releases)._

## 8.6.3

## What's Changed

* Add release notes configuration by @​martincostello in
App-vNext/Polly#2678
* Simplify release workflow by @​martincostello in
App-vNext/Polly#2679
* Sign-off commits by @​martincostello in
App-vNext/Polly#2694
* Add GitHub sponsorship by @​martincostello in
App-vNext/Polly#2695
* Refactor project dependencies by @​martincostello in
App-vNext/Polly#2696
* Add zizmor by @​martincostello in
App-vNext/Polly#2698
* Update benchmarks by @​martincostello in
App-vNext/Polly#2712
* Reduce async overhead by @​pentp in
App-vNext/Polly#2664
* Update benchmarks by @​martincostello in
App-vNext/Polly#2713

## New Contributors

* @​pentp made their first contribution in
App-vNext/Polly#2664

**Full Changelog**:
App-vNext/Polly@8.6.2...8.6.3


## 8.6.2

## What's Changed

* Performance tweaks by @​martincostello in
App-vNext/Polly#2667
* Update dependencies by @​martincostello in
App-vNext/Polly#2668
* Update benchmark results by @​martincostello in
App-vNext/Polly#2669

## New Contributors

* @​pentp made their first contribution in
App-vNext/Polly#2667

**Full Changelog**:
App-vNext/Polly@8.6.1...8.6.2


## 8.6.1

## What's Changed

* Fix integer overflow in `BulkheadSemaphoreFactory` by @​ahusseini in
App-vNext/Polly#2638
* Generate SBOM by @​martincostello in
App-vNext/Polly#2640
* Attest artifacts by @​martincostello in
App-vNext/Polly#2647

## New Contributors

* @​ahusseini made their first contribution in
App-vNext/Polly#2638

**Full Changelog**:
App-vNext/Polly@8.6.0...8.6.1

Commits viewable in [compare
view](App-vNext/Polly@8.5.2...8.6.3).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Polly&package-manager=nuget&previous-version=8.5.2&new-version=8.6.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Sep 8, 2025
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 15, 2025
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
v8.6.1
Development

Successfully merging this pull request may close these issues.

[Bug]: ArgumentOutOfRangeException in BulkheadSemaphoreFactory when passing int.MaxValue for maxQueueingActions
2 participants
@ahusseini @martincostello