-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add zizmor #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zizmor #2698
Conversation
martincostello
commented
Aug 12, 2025
- Use zizmor to scan the GitHub Actions workflows for vulnerabilities.
- Resolve zizmor findings.
- Bump PSScriptAnalyzer to v1.24.0.
- Use zizmor to scan the GitHub Actions workflows for vulnerabilities. - Resolve zizmor findings. - Bump PSScriptAnalyzer to v1.24.0.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds zizmor as a security scanning tool for GitHub Actions workflows and resolves the security findings it identified. It also updates PSScriptAnalyzer to version 1.24.0.
- Adds zizmor workflow security scanning with pedantic persona
- Resolves security findings by adding
persist-credentials: false
to most checkout actions - Updates PSScriptAnalyzer from v1.23.0 to v1.24.0 and removes unnecessary NuGet cache setup
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
.github/workflows/lint.yml |
Adds zizmor security scanning, updates PSScriptAnalyzer version, adds required permissions, and removes NuGet cache |
.github/workflows/updater-approve.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/release.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/on-push-do-docs.yml |
Explicitly sets persist-credentials: true with zizmor ignore comment |
.github/workflows/nuget-packages-published.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/mutation-tests.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/gh-pages.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/dependency-review.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/dependabot-approve.yml |
Adds persist-credentials: false and ref parameter to checkout action, adds zizmor ignore comment |
.github/workflows/code-ql.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/build.yml |
Adds persist-credentials: false to checkout action and removes NuGet cache setup |
.github/workflows/after-release.yml |
Explicitly sets persist-credentials: true with zizmor ignore comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2698 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7322 7322
Branches 1012 1012
=======================================
Hits 7046 7046
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Updated [Polly](https://github.com/App-vNext/Polly) from 8.6.1 to 8.6.3. <details> <summary>Release notes</summary> _Sourced from [Polly's releases](https://github.com/App-vNext/Polly/releases)._ ## 8.6.3 ## What's Changed * Add release notes configuration by @martincostello in App-vNext/Polly#2678 * Simplify release workflow by @martincostello in App-vNext/Polly#2679 * Sign-off commits by @martincostello in App-vNext/Polly#2694 * Add GitHub sponsorship by @martincostello in App-vNext/Polly#2695 * Refactor project dependencies by @martincostello in App-vNext/Polly#2696 * Add zizmor by @martincostello in App-vNext/Polly#2698 * Update benchmarks by @martincostello in App-vNext/Polly#2712 * Reduce async overhead by @pentp in App-vNext/Polly#2664 * Update benchmarks by @martincostello in App-vNext/Polly#2713 ## New Contributors * @pentp made their first contribution in App-vNext/Polly#2664 **Full Changelog**: App-vNext/Polly@8.6.2...8.6.3 ## 8.6.2 ## What's Changed * Performance tweaks by @martincostello in App-vNext/Polly#2667 * Update dependencies by @martincostello in App-vNext/Polly#2668 * Update benchmark results by @martincostello in App-vNext/Polly#2669 ## New Contributors * @pentp made their first contribution in App-vNext/Polly#2667 **Full Changelog**: App-vNext/Polly@8.6.1...8.6.2 Commits viewable in [compare view](App-vNext/Polly@8.6.1...8.6.3). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updated [Polly](https://github.com/App-vNext/Polly) from 8.5.2 to 8.6.3. <details> <summary>Release notes</summary> _Sourced from [Polly's releases](https://github.com/App-vNext/Polly/releases)._ ## 8.6.3 ## What's Changed * Add release notes configuration by @martincostello in App-vNext/Polly#2678 * Simplify release workflow by @martincostello in App-vNext/Polly#2679 * Sign-off commits by @martincostello in App-vNext/Polly#2694 * Add GitHub sponsorship by @martincostello in App-vNext/Polly#2695 * Refactor project dependencies by @martincostello in App-vNext/Polly#2696 * Add zizmor by @martincostello in App-vNext/Polly#2698 * Update benchmarks by @martincostello in App-vNext/Polly#2712 * Reduce async overhead by @pentp in App-vNext/Polly#2664 * Update benchmarks by @martincostello in App-vNext/Polly#2713 ## New Contributors * @pentp made their first contribution in App-vNext/Polly#2664 **Full Changelog**: App-vNext/Polly@8.6.2...8.6.3 ## 8.6.2 ## What's Changed * Performance tweaks by @martincostello in App-vNext/Polly#2667 * Update dependencies by @martincostello in App-vNext/Polly#2668 * Update benchmark results by @martincostello in App-vNext/Polly#2669 ## New Contributors * @pentp made their first contribution in App-vNext/Polly#2667 **Full Changelog**: App-vNext/Polly@8.6.1...8.6.2 ## 8.6.1 ## What's Changed * Fix integer overflow in `BulkheadSemaphoreFactory` by @ahusseini in App-vNext/Polly#2638 * Generate SBOM by @martincostello in App-vNext/Polly#2640 * Attest artifacts by @martincostello in App-vNext/Polly#2647 ## New Contributors * @ahusseini made their first contribution in App-vNext/Polly#2638 **Full Changelog**: App-vNext/Polly@8.6.0...8.6.1 Commits viewable in [compare view](App-vNext/Polly@8.5.2...8.6.3). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>