[Cherry-pick] DYN-9191: RecentFiles bug fix with test fixed #16412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2e34aca)
There was a problem hiding this comment.
Pull Request Overview
This cherry-pick PR fixes a bug in the recent files functionality that caused errors when removing invalid file paths from the recent files list after the maximum limit was reached. The fix includes proper validation of file paths and safer removal logic.
- Adds path validation to filter out invalid entries when loading preferences
- Implements safer collection removal logic in the UI to prevent index out-of-bounds errors
- Updates test configuration to use a relative path for testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/settings/RecentFilesTest.dyn | New test file containing a basic Dynamo graph for testing recent files functionality |
| test/settings/DynamoSettings-NewSettings.xml | Updates test configuration to reference the new test file with relative path |
| src/DynamoCoreWpf/Controls/StartPage.xaml.cs | Fixes UI collection removal logic to handle non-contiguous removed items safely |
| src/DynamoCore/Configuration/PreferenceSettings.cs | Adds validation to filter invalid file paths when loading preferences |
This was referenced Jul 18, 2025
aparajit-pratap
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #16394 and #16411 to RC3.6.0_master
Purpose
When changing recent files cache, in case when max recent files has been reached, removing the last item from the collection would throw an error, if invalid paths exist.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Adds logic to refresh the recent file list when removed items are not contiguous, ensuring the UI stays in sync with the underlying data.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of