Skip to content

MRG: Forgotten weights arg in barycenter funcs #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

hichamjanati
Copy link
Contributor

@hichamjanati hichamjanati commented Oct 19, 2019

  • Tiny fix: the weights arg was not passed in the general barycenter funcs.
  • Loop counter in barycenter_unbalanced was outside the loop -> change while loops to for loops
  • Adding 1e-16 to avoid 0 when dual variables are returned was too conservative and causes large differences in the exponentials. changed to 1e-300

@hichamjanati hichamjanati changed the title FIX: Forgotten weights arg in barycenter funcs MRG: Forgotten weights arg in barycenter funcs Oct 21, 2019
@rflamary rflamary merged commit 65ca6bf into PythonOT:master Oct 24, 2019
@rflamary
Copy link
Collaborator

Thank you Hicham !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants