Skip to content

Fix debug/warn log messages when checking version cached #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix debug/warn log messages when checking version cached #1462

merged 1 commit into from
Sep 20, 2023

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 20, 2023

This PR fixes the log messages shown when there is no version cache file

  • Before:
2023/09/20 14:44:53  WARN reading version file failed: %!w(string=open /opt/buildkite-agent/.elastic-package/latestVersion: no such file or directory)
2023/09/20 14:44:53 DEBUG failed to load latest version from cache: %vreading version file failed: open /opt/buildkite-agent/.elastic-package/latestVersion: no such file or directory
2023/09/20 14:44:53 DEBUG checking latest release in Github
  • With these changes
2023/09/20 16:52:57  WARN reading version file failed: open /home/mariorodriguez/.elastic-package/latestVersion: no such file or directory
2023/09/20 16:52:57 DEBUG failed to load latest version from cache: reading version file failed: open /home/mariorodriguez/.elastic-package/latestVersion: no such file or directory
2023/09/20 16:52:57 DEBUG checking latest release in Github

@mrodm mrodm requested a review from a team September 20, 2023 14:57
@mrodm mrodm self-assigned this Sep 20, 2023
jsoriano
jsoriano approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

@mrodm mrodm merged commit 41e5ea5 into elastic:main Sep 20, 2023
@mrodm mrodm deleted the fix_error_messages_cache_version branch September 20, 2023 15:46
bhapas pushed a commit to bhapas/elastic-package that referenced this pull request Sep 21, 2023
@mrodm @bhapas
Fix debug/warn log messages when checking version cached (elastic#1462)
09ff230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mrodm mrodm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrodm @elasticmachine @jsoriano