Skip to content

Fix debug/warn log messages when checking version cached #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix debug/warn log messages when checking version cached #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/version/check_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func CheckUpdate() {
latestVersion, err := loadCacheLatestVersion()
switch {
case err != nil:
logger.Debug("failed to load latest version from cache: %v", err)
logger.Debugf("failed to load latest version from cache: %v", err.Error())
default:
expired = checkCachedLatestVersion(latestVersion, defaultCacheDuration)
}
Expand Down Expand Up @@ -139,7 +139,7 @@ func loadCacheLatestVersion() (*versionLatest, error) {
latestVersionPath := filepath.Join(elasticPackagePath.RootDir(), latestVersionFile)
contents, err := os.ReadFile(latestVersionPath)
if err != nil {
logger.Warnf("reading version file failed: %w", err.Error())
logger.Warnf("reading version file failed: %v", err.Error())
return nil, fmt.Errorf("reading version file failed: %w", err)
}

Expand Down