IBX-10215: Fixed SourceLanguageValueResolver argument's name
#1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
ViniTou,
wiewiurdp,
konradoboza and
tbialcz
and removed request for
a team
konradoboza
reviewed
Jun 27, 2025
barw4
changed the title
TargetLanguageValueResolver argument's nameSourceLanguageValueResolver argument's name
I updated the description |
konradoboza
approved these changes
Jun 27, 2025
alongosz
approved these changes
Jun 27, 2025
adamwojs
approved these changes
Jun 28, 2025
barw4
added
Ready for QA
and removed
Bug
barw4
changed the title
SourceLanguageValueResolver argument's nameSourceLanguageValueResolver argument's name
KamilSznajdrowicz
force-pushed
the
ibx-10125-fix-target-language-value-resolver
branch
from
a7203a4 to
ad4f98e
Compare
|
KamilSznajdrowicz
requested changes
Jul 10, 2025
KamilSznajdrowicz
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
QA Approved
Regression: ibexa/commerce#1390 (the regression fails isn't related to these PRs.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
https://github.com/ibexa/product-catalog/pull/1364
Description:
Fix to the obvious typo : )
Almost every 'update' controller action has the following param:
baseLanguage, i.e.: https://github.com/ibexa/admin-ui/blob/main/src/bundle/Controller/ContentTypeController.php#L472 which is in fact resolved inSourceLanguageValueResolver-> the argument name cannot be the same as inTargetLanguageValueResolver.For QA:
Documentation: