Skip to content

IBX-10215: Fixed SourceLanguageValueResolver argument's name #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

IBX-10215: Fixed SourceLanguageValueResolver argument's name #1612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d42130a
IBX-10125: Fixed `TargetLanguageValueResolver` argument's name
barw4 Jun 26, 2025
ad4f98e
IBX-10125: Fixed unit test
barw4 Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bundle/ValueResolver/SourceLanguageValueResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*/
final class SourceLanguageValueResolver extends AbstractValueResolver
{
private const string ARGUMENT_NAME = 'language';
private const string ARGUMENT_NAME = 'baseLanguage';
private const string ATTRIBUTE_LANGUAGE_CODE_FROM = 'fromLanguageCode';

public function __construct(
Expand Down
2 changes: 1 addition & 1 deletion tests/bundle/ValueResolver/SourceLanguageValueResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function testResolve(): void
$argumentMetadata->method('getType')
->willReturn(Language::class);
$argumentMetadata->method('getName')
->willReturn('language');
->willReturn('baseLanguage');

$request = new Request([], [], $attributes);

Expand Down
Loading