-
Notifications
You must be signed in to change notification settings - Fork 798
[CI] Add backward ABI-compatibility testing to pre-commit #19719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
24abdd8
984bd3d
f98151e
b6fdc95
2405ebe
fd6a97d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
# Known OK: | ||
|
||
# https://github.com/intel/llvm/pull/18059 made property a no-op, so `FileCheck` | ||
# fails, but that isn't an actual ABI break. | ||
DiscardEvents/discard_events_accessors.cpp | ||
DiscardEvents/discard_events_using_assert_ndebug.cpp | ||
DiscardEvents/discard_events_usm.cpp | ||
DiscardEvents/invalid_event.cpp | ||
DiscardEvents/invalid_event_exceptions.cpp | ||
|
||
# https://github.com/intel/llvm/pull/18287 | ||
# Throw exception instead of returning garbage | ||
Basic/info.cpp | ||
|
||
# Likely OK, but need author to provide justification, get approval/confirmation | ||
# from someone: | ||
|
||
# https://github.com/intel/llvm/pull/18565 | ||
# This one should have probably be done in multiple PRs, first improving the | ||
# test's CHECKs and then making an actual functional change. | ||
# | ||
# Based on the title, I'd expect to see reduction in number of ur*retain/release | ||
# calls, but it only moves a few ur*release CHECKs, so I'll let the author | ||
# update this explanation. | ||
Comment on lines
+18
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Alexandr-Konovalov , please upload a PR that updates this comment with explanation how the change wasn't ABI-breaking. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Opened [CI] Add clarification for KernelAndProgram/disable-caching change #19822 |
||
KernelAndProgram/disable-caching.cpp | ||
|
||
# https://github.com/intel/llvm/pull/18253 broke at least some of the pre-built | ||
# E2E binaries, but do we really need to provide backward compatibility for | ||
# binaries built with sanitizers? | ||
Sanitizer | ||
|
||
# https://github.com/intel/llvm/pull/19238 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @AndreiZibrov , please upload a PR that updates this with an explanation why this was desired (I'd expect something along the lines of allowing ABI breaks in an experimental extension). Also tagging @AlexeySachkov There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aelovikov-intel - Do you have the output of this failure at hand? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Easy to generate :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! Clarification here: #19774 |
||
NonUniformGroups/opportunistic_group.cpp | ||
|
||
# https://github.com/intel/llvm/pull/17955, experimental extension | ||
AsyncAlloc/device/async_alloc_from_pool.cpp | ||
AsyncAlloc/device/async_alloc_zero_init.cpp | ||
AsyncAlloc/device/ooo_queue_async_alloc_from_pool.cpp | ||
Comment on lines
+35
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @intel/sycl-graphs-reviewers , can you please check if that break was intentional and if so update the comment here? Using 2025-06-18 (pass): https://github.com/intel/llvm/actions/runs/16884717829 |
||
|
||
# Need more investigation by the author: | ||
|
||
# https://github.com/intel/llvm/pull/18314 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Alexandr-Konovalov , looks like your #18314 broke backward compatibility here, see There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, an interesting issue! Opened [SYCL] Add copy/move ctors and assignment operators to sycl::detail::optional #19775. |
||
Assert/assert_in_kernels.cpp | ||
Assert/assert_in_multiple_tus.cpp | ||
Assert/assert_in_multiple_tus_one_ndebug.cpp | ||
Assert/assert_in_one_kernel.cpp | ||
Assert/assert_in_simultaneous_kernels.cpp | ||
Assert/assert_in_simultaneously_multiple_tus.cpp | ||
Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp | ||
|
||
# https://github.com/intel/llvm/pull/17442 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @steffenlarsen , looks like your #17442 broke backward compatibility here, see There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do! Great addition, by the way! See #19764. |
||
KernelCompiler/opencl.cpp | ||
KernelCompiler/opencl_cache_eviction.cpp | ||
KernelCompiler/opencl_queries.cpp | ||
|
||
# https://github.com/intel/llvm/pull/18403 (pulldown, so probably offload-tools | ||
# team should be looking into this) | ||
DeviceImageDependencies/NewOffloadDriver/dynamic.cpp | ||
DeviceImageDependencies/NewOffloadDriver/free_function_kernels.cpp | ||
DeviceImageDependencies/NewOffloadDriver/math_device_lib.cpp | ||
DeviceImageDependencies/NewOffloadDriver/objects.cpp | ||
DeviceImageDependencies/NewOffloadDriver/singleDynamicLibrary.cpp | ||
NewOffloadDriver/aot-gpu.cpp | ||
NewOffloadDriver/buffer.cpp | ||
NewOffloadDriver/multisource.cpp | ||
NewOffloadDriver/spirv_device_obj_smoke.cpp | ||
NewOffloadDriver/split-per-source-main.cpp | ||
NewOffloadDriver/sycl-external-with-optional-features.cpp | ||
Comment on lines
+56
to
+68
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @intel/dpcpp-tools-reviewers , looks like #18403 pulldown broke backward compatibility here https://github.com/intel/llvm/actions/runs/16883874414 (using nightly-2025-05-16, pass) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was suggested to me to tag @asudarsa here. |
||
|
||
# https://github.com/intel/llvm/pull/18277 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @igchor , looks like your #18277 broke backward compatibility here, see https://github.com/intel/llvm/actions/runs/16883391382 (using nightly-2025-05-19, pass) |
||
InOrderEventsExt/get_last_event.cpp | ||
InorderQueue/in_order_ext_oneapi_submit_barrier.cpp | ||
|
||
# https://github.com/intel/llvm/pull/19328 | ||
Adapters/interop-level-zero-buffer-ownership.cpp | ||
Comment on lines
+74
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @igchor , looks like your #19328 broke backward compatibility here, see https://github.com/intel/llvm/actions/runs/16883683175 (using nightly-2025-07-10, pass) |
Uh oh!
There was an error while loading. Please reload this page.