[CI] Backward-compatibility testing against sycl-rel-6_3
#19761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like we have three runners with `pvc` label and only one of them has `build` on it too (and we have three more non-`pvc` `build` runners), so I wouldn't expect `pvc` tasks to be a bottleneck.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
reviewed
Aug 11, 2025
| @@ -83,7 +83,8 @@ jobs: | |||
| name: Read compatibility testing exclude list | |||
| runs-on: [Linux, build] | |||
| outputs: | |||
| FILTER: ${{ steps.result.outputs.FILTER }} | |||
| FILTER_6_2: ${{ steps.result.outputs.FILTER_6_2 }} | |||
There was a problem hiding this comment.
any way we could call this from a matrix so dont ned to add a new variable for every release?
There was a problem hiding this comment.
I don't think we want that actually. Matrix would result in multiple jobs spawning instead of allocating a runner just once here. Also, we will be dropping those with every major/abi-breaking release, so it won't grow that much.
sarnex
approved these changes
Aug 11, 2025
|
Failures are unrelated - those jobs weren't affected by the changes. SPIR-V Backend looks flaky and BMG was infrastructural. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Aug 18, 2025
intel#19719 and intel#19761 added pre-commit jobs to run E2E tests pre-built with latest "open-source" releases against the newly built sycl-toolchain libraries. Those can fail if either an actual break is happenning or if the test was doing some `FileCheck`ing and that output has changed in some way (which might not be an actual ABI break). However, I think the testing is still good enough to require an explicit approvals by folks in charge of ABI breaking changes. For the case of just output change the author should be able to convince owners that the change isn't ABI-breaking relatively easily.
aelovikov-intel
added a commit
that referenced
this pull request
Aug 18, 2025
…19820) #19719 and #19761 added pre-commit jobs to run E2E tests pre-built with latest "open-source" releases against the newly built sycl-toolchain libraries. Those can fail if either an actual break is happenning or if the test was doing some `FileCheck`ing and that output has changed in some way (which might not be an actual ABI break). However, I think the testing is still good enough to require an explicit approvals by folks in charge of ABI breaking changes. For the case of just output change the author should be able to convince owners that the change isn't ABI-breaking relatively easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we have three runners with
pvclabel and only one of them hasbuildon it too (and we have three more non-pvcbuildrunners), so I wouldn't expectpvctasks to be a bottleneck.