Skip to content

[CI] Backward-compatibility testing against sycl-rel-6_3 #19761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

[CI] Backward-compatibility testing against sycl-rel-6_3 #19761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/sycl-linux-precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ jobs:
name: Read compatibility testing exclude list
runs-on: [Linux, build]
outputs:
FILTER: ${{ steps.result.outputs.FILTER }}
FILTER_6_2: ${{ steps.result.outputs.FILTER_6_2 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way we could call this from a matrix so dont ned to add a new variable for every release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want that actually. Matrix would result in multiple jobs spawning instead of allocating a runner just once here. Also, we will be dropping those with every major/abi-breaking release, so it won't grow that much.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks

FILTER_6_3: ${{ steps.result.outputs.FILTER_6_3 }}
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -96,7 +97,8 @@ jobs:
run: |
# Transform to format expected by `llvm-lit --filter-out "pattern1|pattern2|..."`.
# First, remove comments/empty lines, then join lines with "|" as separator.
echo FILTER="$(grep -v '^#\|^\W*$' devops/compat_ci_exclude.sycl-rel-6_2 | paste -sd '|')" >> $GITHUB_OUTPUT
echo FILTER_6_2="$(grep -v '^#\|^\W*$' devops/compat_ci_exclude.sycl-rel-6_2 | paste -sd '|')" >> $GITHUB_OUTPUT
echo FILTER_6_3="$(grep -v '^#\|^\W*$' devops/compat_ci_exclude.sycl-rel-6_3 | paste -sd '|')" >> $GITHUB_OUTPUT
run_prebuilt_e2e_tests:
needs: [build, detect_changes, compat_read_exclude]
Expand Down Expand Up @@ -147,7 +149,13 @@ jobs:
runner: '["Linux", "pvc"]'
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_2
target_devices: level_zero:gpu
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER }}"'
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_2 }}"'
e2e_binaries_artifact: 'in-container'
- name: ABI compatibility against sycl-rel-6_3
runner: '["Linux", "pvc"]'
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_3
target_devices: level_zero:gpu
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_3 }}"'
e2e_binaries_artifact: 'in-container'

uses: ./.github/workflows/sycl-linux-run-tests.yml
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sycl-linux-run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ on:
options:
- 'ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest'
- 'ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_2'
- 'ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_3'
- 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'
image_options:
description: |
Expand Down
24 changes: 24 additions & 0 deletions devops/compat_ci_exclude.sycl-rel-6_3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Failed against sycl-rel-6_3 toolchain when creating the container:
Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp
Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp

# Likely OK, but need author to provide justification, get approval/confirmation
# from someone:

# https://github.com/intel/llvm/pull/18565
# This one should have probably be done in multiple PRs, first improving the
# test's CHECKs and then making an actual functional change.
#
# Based on the title, I'd expect to see reduction in number of ur*retain/release
# calls, but it only moves a few ur*release CHECKs, so I'll let the author
# update this explanation.
KernelAndProgram/disable-caching.cpp

# https://github.com/intel/llvm/pull/19238
NonUniformGroups/opportunistic_group.cpp

# The test is extremely hacky and relies on CI installing some extra files that
# are used during test execution. Looks like we need that to come from the
# toolchain used to build the test, not the toolchain we're using SYCL RT from
# to run against pre-built E2E binaries.
Basic/device_config_file_consistency.cpp
Loading