Use em instead of i and strong instead of b

[XhmikosR]

They are semantically more correct

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

1. Base your code and PRs against the repositories developmental branch.
2. Sign Off all commits as we enforce the DCO for all contributions
3. Sign all your commits as they must have verified signatures
4. File a pull request for any change that requires changes to our documentation at our documentation repo

---

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• I have read the above and my PR is ready for review. Check this box to confirm

[XhmikosR]

No need to overqualify the selector: this should work the same.

[PromoFaux]

Huh, well I just went down a rabbit hole of interesting reading - so I guess thanks!

From https://www.w3.org/International/questions/qa-b-and-i-tags:

The b element should be used as a last resort when no other element is more appropriate.

[PromoFaux]

Can we add some kind of style linting to ensure consistency going forward?

[XhmikosR]

At this point, I'd say no... I'm not aware of any tools that support this, especially with Lua templates.

[PromoFaux]

Maybe a quick and dirty smoke test that parses all *.lp files for <i> or <b>

[XhmikosR]

I don't have the bandwidth to add this, but feel free to make an issue to track the request and move with this regardless :)

[PromoFaux]

TBH, because of reasons mentioned by RD here, this would be a difficult thing to lint anyway - as apparently there are some valid uses of <i> and <b> in the codebase.

I started looking into why FontAwesome suggest <i> instead of, say, <span> - turns out that it's for brevity. i is three less chars than span

https://stackoverflow.com/questions/21559816/why-does-font-awesome-recommend-using-i-elements-instead-of-span-elements-i#comment44356924_21559816

[XhmikosR]

Yeah, this patch needs human eyes. I don't think it can be automated.