Skip to content

Use em instead of i and strong instead of b #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion groups-lists.lp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ mg.include('scripts/lua/header_authenticated.lp','r')
<strong>Hints:</strong>
<ol>
<li>Please run <code>pihole -g</code> or update your gravity list <a href="<?=webhome?>gravity">online</a> after modifying your lists.</li>
<li>Multiple lists can be added by separating each <i>unique</i> URL with a space or comma</li>
<li>Multiple lists can be added by separating each <em>unique</em> URL with a space or comma</li>
<li>Click on the icon in the first column to get additional information about your lists. The icons correspond to the health of the list.</li>
</ol>
<div class="btn-toolbar pull-right" role="toolbar" aria-label="Toolbar with buttons">
Expand Down
4 changes: 3 additions & 1 deletion scripts/js/settings-dns-records.js
Original file line number Diff line number Diff line change
Expand Up @@ -264,5 +264,7 @@ $(document).ready(function () {
});

// Add a small legend below the CNAME table
$("#cnameRecords-Table").after("<small>* <b>TTL</b> in seconds <i>(optional)</i></small>");
$("#cnameRecords-Table").after(
"<small>* <strong>TTL</strong> in seconds <em>(optional)</em></small>"
);
});
4 changes: 2 additions & 2 deletions scripts/js/taillog.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ function formatDnsmasq(line) {

if (line.includes("denied") || line.includes("gravity blocked")) {
// Red bold text for blocked domains
txt = `<b class="log-red">${txt}</b>`;
txt = `<strong class="log-red">${txt}</strong>`;
} else if (line.includes("query[A") || line.includes("query[DHCP")) {
// Bold text for initial query lines
txt = `<b>${txt}</b>`;
txt = `<strong>${txt}</strong>`;
} else {
// Grey text for all other lines
txt = `<span class="text-muted">${txt}</span>`;
Expand Down
2 changes: 1 addition & 1 deletion settings-dnsrecords.lp
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ mg.include('scripts/lua/settings_header.lp','r')
<strong>Note:</strong>
<p>The target of a <code>CNAME</code> must be a domain that the Pi-hole already has in its cache or is authoritative for. This is a universal limitation of <code>CNAME</code> records.</p>
<p>The reason for this is that Pi-hole will not send additional queries upstream when serving <code>CNAME</code> replies. As consequence, if you set a target that isn't already known, the reply to the client may be incomplete. Pi-hole just returns the information it knows at the time of the query. This results in certain limitations for <code>CNAME</code> targets,
for instance, only <i>active</i> DHCP leases work as targets - mere DHCP <i>leases</i> aren't sufficient as they aren't (yet) valid DNS records.</p>
for instance, only <em>active</em> DHCP leases work as targets - mere DHCP <i>leases</i> aren't sufficient as they aren't (yet) valid DNS records.</p>
<p>Additionally, you can't <code>CNAME</code> external domains (<code>bing.com</code> to <code>google.com</code>) successfully as this could result in invalid SSL certificate errors when the target server does not serve content for the requested domain.</p>
<p>Adding/removing local CNAME records will restart the DNS server.</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion style/themes/high-contrast-dark.css
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ kbd {
background: #181c20;
font-size: 14px;
}
#output b.log-red {
#output .log-red {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to overqualify the selector: this should work the same.

background: #b23;
color: #fff;
}
Expand Down
2 changes: 1 addition & 1 deletion style/themes/high-contrast.css
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ a:hover {
#output {
font-size: 14px;
}
#output b.log-red {
#output .log-red {
background: #c00;
color: #fff;
}
Expand Down