-
Notifications
You must be signed in to change notification settings - Fork 79
Closed
Labels
devopsDevOps relatedDevOps related
Milestone
Description
Changes/improvements to setup.py
from @juanitorduz in #79 ended up breaking the pypi build when I released version 0.0.4. I quickly fixed this with #99 by rolling back changes to setup.py
.
At the moment, it's not clear if the error was coming from how the version is dealt with (line below works fine and is good)
Line 17 in 127f384
exec(open("causalpy/version.py").read()) |
or changes to how requirements files were being read in and dealt with.
Thoughts:
- Can we actually entirely remove
setup.py
and just havepyproject.toml
? - If not, then:
- We should improve versioning, perhaps by using https://github.com/peritus/bumpversion, which will make it easier to automate the version release process.
- See if we can revert back to @juanitorduz's improvements to how requirements were deal with, and not break the pypi build.
Metadata
Metadata
Assignees
Labels
devopsDevOps relatedDevOps related