Skip to content

setup.py: fix or kill #105

@drbenvincent

Description

@drbenvincent

Changes/improvements to setup.py from @juanitorduz in #79 ended up breaking the pypi build when I released version 0.0.4. I quickly fixed this with #99 by rolling back changes to setup.py.

At the moment, it's not clear if the error was coming from how the version is dealt with (line below works fine and is good)

exec(open("causalpy/version.py").read())

or changes to how requirements files were being read in and dealt with.

Thoughts:

  • Can we actually entirely remove setup.py and just have pyproject.toml?
  • If not, then:
    • We should improve versioning, perhaps by using https://github.com/peritus/bumpversion, which will make it easier to automate the version release process.
    • See if we can revert back to @juanitorduz's improvements to how requirements were deal with, and not break the pypi build.

Metadata

Metadata

Assignees

No one assigned

    Labels

    devopsDevOps related

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions