-
Notifications
You must be signed in to change notification settings - Fork 79
Basic Ci/CD and fix code style #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The lint check detected a duplicated name
|
Ok! Thanks for checking! It might be I messed up something when resolving conflicts. I'll take a look 🙈 |
But in line 66 you also have a generate_time_seried_data function right? (Same name ?) |
I'm not sure what's going on. From a search I only got 2 hits. But yes, I see now. Maybe just too much coding for one day! |
Do we need to add the generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked all this over and run the pre-commit checks locally, and the various make commands. Made one commit a moment ago to fix a duplicated function definition. Everything seems fine at this point.
I think you must have merged main into this branch after my updates on Wed evening, but if you can just confirm then I can approve and we can merge.
@drbenvincent , in 5a74cd8 I added some changes which make the version setting easier. Also fixed some missing lint problems. If you see the ci/cd output now is green: https://github.com/juanitorduz/CausalPy/actions/runs/3539004142/jobs/5940424788 Please take a look into it and test locally by running |
Partially closes #57
This PR:
@drbenvincent, please double-check the small changes I had to do to fix the style. Feel free to push changes to the branch. I tried to change the least as possible.
Note that the tests and lint are passing on my fork: https://github.com/juanitorduz/CausalPy/actions/runs/3517816662/jobs/5896022154