Correctly handle when there are no unstable items in the documented crate #145349
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @notriddle rustbot has assigned @notriddle. Use |
rustbot
added
A-rustdoc-search
|
Some changes occurred in HTML/CSS/JS. |
|
Just curious, is there any more minimal way to reproduce the bug locally? |
|
I couldn't find one. It's very frustrating. |
|
I'm wondering if it would be something like "document crate X with an old rustdoc version, then redocument it with a new rustdoc version" in a such way that the generated |
|
We always link to the right JS files, so I don't think it would trigger it (just tested and I confirm it didn't). |
lolbinarycat
approved these changes
Aug 13, 2025
|
@bors r=lolbinarycat,fmease rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 13, 2025
…ch, r=lolbinarycat,fmease Correctly handle when there are no unstable items in the documented crate Fixes rust-lang#145287. cc `@lolbinarycat`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 13, 2025
…ch, r=lolbinarycat,fmease Correctly handle when there are no unstable items in the documented crate Fixes rust-lang#145287. cc ``@lolbinarycat``
This was referenced Aug 13, 2025
bors
added a commit
that referenced
this pull request
Aug 13, 2025
Rollup of 9 pull requests Successful merges: - #144761 (aarch64: Make `outline-atomics` a known target feature) - #144949 (More `Printer` cleanups) - #144955 (search graph: lazily update parent goals) - #144962 (Add aarch64_be-unknown-none-softfloat target) - #145153 (Handle macros with multiple kinds, and improve errors) - #145241 ([AVR] Changed data_layout) - #145341 (Install libgccjit into the compiler's sysroot when cg_gcc is enabled) - #145349 (Correctly handle when there are no unstable items in the documented crate) - #145356 (Add another example for escaped `#` character in doctest in rustdoc book) r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Aug 14, 2025
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 14, 2025
…fmease [rustdoc] Revert "rustdoc search: prefer stable items in search results" Reverts rust-lang#141658 and reverts rust-lang#145349. Reopens rust-lang#138067. r? `@fmease`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145287.
cc @lolbinarycat