Skip to content

WIP: Exploring Compose Runtime Integration. #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: Exploring Compose Runtime Integration. #814

wants to merge 1 commit into from

Conversation

steve-the-edwards
Copy link
Contributor

No description provided.

@steve-the-edwards steve-the-edwards force-pushed the sedwards/empty-channel branch 9 times, most recently from d058bea to 2fab83d Compare June 22, 2022 19:46
Base automatically changed from sedwards/empty-channel to main June 22, 2022 20:53
@steve-the-edwards steve-the-edwards force-pushed the sedwards/compose_runtime_explorations branch from cfcd9b2 to f42f446 Compare June 24, 2022 21:53
@steve-the-edwards steve-the-edwards changed the title WIP: Molecule Addition WIP: Exploring Compose Runtime Integration. Jun 24, 2022
@steve-the-edwards steve-the-edwards force-pushed the sedwards/compose_runtime_explorations branch 2 times, most recently from 0f6b419 to d606270 Compare June 27, 2022 20:48
@steve-the-edwards
Copy link
Contributor Author

Stuck as I can get my render pass counting app, interceptors, and ui test to compile but there is a runtime error finding the render() method that is @Composable (i.e. takes a Composer).

java.lang.NoSuchMethodError: No virtual method render(Ljava/lang/Object;Ljava/lang/Object;Lcom/squareup/workflow1/StatefulWorkflow$RenderContext;Landroidx/compose/runtime/Composer;I)Ljava/lang/Object; in class Lcom/squareup/workflow1/StatefulWorkflow; or its super classes (declaration of 'com.squareup.workflow1.StatefulWorkflow' appears in /data/app/~~8bovFPIbV5ciYsICdbra7Q==/com.squareup.benchmarks.performance.complex.poetry-MA3xHPT0hPSEr--l1p1kwg==/base.apk!classes2.dex)

I'm stumped atm.

@steve-the-edwards
Copy link
Contributor Author

Stuck as I can get my render pass counting app, interceptors, and ui test to compile but there is a runtime error finding the render() method that is @Composable (i.e. takes a Composer).

java.lang.NoSuchMethodError: No virtual method render(Ljava/lang/Object;Ljava/lang/Object;Lcom/squareup/workflow1/StatefulWorkflow$RenderContext;Landroidx/compose/runtime/Composer;I)Ljava/lang/Object; in class Lcom/squareup/workflow1/StatefulWorkflow; or its super classes (declaration of 'com.squareup.workflow1.StatefulWorkflow' appears in /data/app/~~8bovFPIbV5ciYsICdbra7Q==/com.squareup.benchmarks.performance.complex.poetry-MA3xHPT0hPSEr--l1p1kwg==/base.apk!classes2.dex)

I'm stumped atm.

Seems like this just means that the compose compiler isn't running on these files as I want it to?

@steve-the-edwards
Copy link
Contributor Author

Seems like this just means that the compose compiler isn't running on these files as I want it to?

Maybe the Compose Compiler not running on these modules?

@steve-the-edwards
WIP: Exploring Compose Runtime Integration
e768363 
Can we just use MutableState inside the WorkflowNode.

Current problem is finding the render() functions with the `Composer` on the class path ?
@steve-the-edwards steve-the-edwards force-pushed the sedwards/compose_runtime_explorations branch from d606270 to e768363 Compare June 28, 2022 15:19
@steve-the-edwards
Copy link
Contributor Author

Closing this in favour of #823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein will be requested when the pull request is marked ready for review zach-klippenstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steve-the-edwards