Compose Runtime Integration Take 2 #823
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/compose-take-2
branch
2 times, most recently
from
28155a8 to
9efe031
Compare
steve-the-edwards
force-pushed
the
sedwards/compose-take-2
branch
from
9efe031 to
eec92fa
Compare
| renderState: IsLoading, | ||
| context: RenderContext, | ||
| hoistRendering: @Composable (rendering: MayBeLoadingScreen) -> Unit | ||
| ) { |
There was a problem hiding this comment.
I'm stumped here. These overrides are recognized by the compiler as it runs in the IDE but when tracing through the call always goes through to the base StatefulWorkflow::Rendering implementation?
@zach-klippenstein any idea why this override wouldn't be recognized at runtime?
There was a problem hiding this comment.
Reproduced in small project. I believe bug in Molecule - cashapp/molecule#91
| hoistRendering: @Composable (rendering: RenderingT) -> Unit | ||
| ): Unit { | ||
| // By default call render() as a fallback. | ||
| hoistRendering(render(renderProps, renderState, context)) |
There was a problem hiding this comment.
I did this so I don't have to modify every workflow and test to get this to compile. However, at runtime the Workflow.Rendering gets resolved here rather than to the child function. 😢
There was a problem hiding this comment.
|
Closed in favour of #824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.