-
Notifications
You must be signed in to change notification settings - Fork 645
Fix rand interval #3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rand interval #3321
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3321 +/- ##
==========================================
- Coverage 46.31% 46.30% -0.01%
==========================================
Files 414 414
Lines 60979 60976 -3
==========================================
- Hits 28240 28234 -6
- Misses 32739 32742 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cargo.toml
Outdated
cubecl = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "88031fed04483e317169d41057e95c531b387fae" } | ||
cubecl-common = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "88031fed04483e317169d41057e95c531b387fae" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked: tracel-ai/cubecl#753
TODO: update rev
Marking it as draft before we accidentally merge this 😅 need to wrap some things up on the cubecl side to fix the no-std build which was previously failing due to new profiling stuff. |
Checklist
cargo run-checks
command has been executed.Related Issues/PRs
Changes
assert_within_range
to support different element types for comparisonTesting
Given the randomness of the source, the issue is not always reproducible. Best way is to generate a bunch of random numbers many times, but this might not be suitable for actual unit tests: