Skip to content

Fix no-std usage profiling #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2025
Merged

Fix no-std usage profiling #753

merged 5 commits into from
Jul 2, 2025

Conversation

laggui
Copy link
Member

@laggui laggui commented Jun 27, 2025 •
edited
Loading

Can't build on no-std platforms with the latest profiling changes (require web_time::Instant).

Quick fix is to use assembly-time when bare metal. But maybe we want to add a profile or profiling feature in the future instead?

Validate your PR with burn.

It is important that you make sure that you don't introduce any bugs in burn.

Instructions

  • Create a new branch or fork of the burn repo
  • Update the main Cargo.toml with this PR hash.
  • Fix any broken tests or compilation errors in burn.
  •  Submit a PR in burn with your fixes and link it here.

@laggui laggui mentioned this pull request Jun 27, 2025
Merged
1 task
@laggui laggui marked this pull request as ready for review July 2, 2025 13:50
@laggui laggui requested a review from nathanielsimard July 2, 2025 13:58
@nathanielsimard nathanielsimard merged commit 3de9206 into main Jul 2, 2025
5 checks passed
@nathanielsimard nathanielsimard deleted the fix/no-std-profile branch July 2, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laggui @nathanielsimard