Expose foreign key constraint options in inline FK definition and in create_constraint
#653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
force-pushed
the
feature-use-fk-constraints-everywhere
branch
from
593deaa to
0afae1d
Compare
kvch
changed the title
create_constraint
|
I am adding more tests. |
New options are added to inline FK constraints and to `create_constraint` operation
kvch
force-pushed
the
feature-use-fk-constraints-everywhere
branch
from
661b56c to
9196f82
Compare
|
I rebased the branch and added tests. |
andrew-farries
approved these changes
Feb 6, 2025
| @@ -404,8 +404,10 @@ func (w *ConstraintSQLWriter) WriteForeignKey(referencedTable string, referenced | |||
| if w.Name != "" { | |||
| constraint = fmt.Sprintf("CONSTRAINT %s ", pq.QuoteIdentifier(w.Name)) | |||
| } | |||
| constraint += fmt.Sprintf("FOREIGN KEY (%s) REFERENCES %s (%s) MATCH %s ON DELETE %s ON UPDATE %s", | |||
| strings.Join(quoteColumnNames(w.Columns), ", "), | |||
| if len(w.Columns) != 0 { | |||
There was a problem hiding this comment.
Under what circumstances would we have 0 columns here?
There was a problem hiding this comment.
In case of inline FK constraints. I am adding a comment so it's clear.
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now more foreign key options are supported:
match_typein column definitions and increate_constrainton_updatein column definitions and increate_constrainton_delete_set_columnsincreate_constrainton_updatein inline FK definitions in a column'sreferencesmatch_typein inline FK definction in a column'sreferencesExtracted from #628. The only remaining part of that PR is adding support in
sql2pgroll. 🎉