Skip to content

[AWS Health] Improve error message reporting #45408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 19, 2025
Merged

[AWS Health] Improve error message reporting #45408

merged 4 commits into from
Jul 19, 2025

Conversation

lucian-ioan
Copy link
Contributor

Proposed commit message

Make error messages explicit by parsing them using smithy library.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@lucian-ioan lucian-ioan requested review from gpop63 and agithomas July 16, 2025 14:39
@lucian-ioan lucian-ioan self-assigned this Jul 16, 2025
@lucian-ioan lucian-ioan requested a review from a team as a code owner July 16, 2025 14:39
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lucian-ioan lucian-ioan added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Jul 16, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 16, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @lucian-ioan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@lucian-ioan
Copy link
Contributor Author

@agithomas Do we need any backport labels here?

@lucian-ioan lucian-ioan added backport-8.18 Automated backport to the 8.18 branch backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches and removed backport-8.18 Automated backport to the 8.18 branch labels Jul 18, 2025
agithomas
agithomas approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucian-ioan lucian-ioan merged commit 1637c55 into elastic:main Jul 19, 2025
36 checks passed
@github-actions GitHub Actions
Copy link
Contributor

@Mergifyio backport 8.17 8.18 8.19 9.0 9.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 19, 2025 •
edited
Loading

backport 8.17 8.18 8.19 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 19, 2025
@lucian-ioan @mergify
[AWS Health] Improve error message reporting (#45408)
0d30313 
* parse error message

* remove comment

* fix CI

* add changelog entry

(cherry picked from commit 1637c55)

# Conflicts:
#	x-pack/metricbeat/module/aws/awshealth/awshealth.go
@mergify mergify bot mentioned this pull request Jul 19, 2025
Open
6 tasks
mergify bot pushed a commit that referenced this pull request Jul 19, 2025
@lucian-ioan @mergify
[AWS Health] Improve error message reporting (#45408)
af05557 
* parse error message

* remove comment

* fix CI

* add changelog entry

(cherry picked from commit 1637c55)

# Conflicts:
#	x-pack/metricbeat/module/aws/awshealth/awshealth.go
@mergify mergify bot mentioned this pull request Jul 19, 2025
Open
6 tasks
mergify bot pushed a commit that referenced this pull request Jul 19, 2025
@lucian-ioan @mergify
[AWS Health] Improve error message reporting (#45408)
b0b3fd7 
* parse error message

* remove comment

* fix CI

* add changelog entry

(cherry picked from commit 1637c55)
@mergify mergify bot mentioned this pull request Jul 19, 2025
Open
6 tasks
mergify bot pushed a commit that referenced this pull request Jul 19, 2025
@lucian-ioan @mergify
[AWS Health] Improve error message reporting (#45408)
a079a83 
* parse error message

* remove comment

* fix CI

* add changelog entry

(cherry picked from commit 1637c55)
mergify bot pushed a commit that referenced this pull request Jul 19, 2025
@lucian-ioan @mergify
[AWS Health] Improve error message reporting (#45408)
fe8de07 
* parse error message

* remove comment

* fix CI

* add changelog entry

(cherry picked from commit 1637c55)

# Conflicts:
#	x-pack/metricbeat/module/aws/awshealth/awshealth.go
This was referenced Jul 19, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@agithomas agithomas agithomas approved these changes

@mykola-elastic mykola-elastic mykola-elastic approved these changes

@gpop63 gpop63 Awaiting requested review from gpop63

Assignees

@lucian-ioan lucian-ioan

Labels
backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches bug Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS Health] Improved error message reporting
4 participants
@lucian-ioan @Kavindu-Dodan @agithomas @mykola-elastic