Skip to content

[9.0](backport #45408) [AWS Health] Improve error message reporting #45483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Open

[9.0](backport #45408) [AWS Health] Improve error message reporting #45483

wants to merge 1 commit into from
+37 −2

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2025

Proposed commit message

Make error messages explicit by parsing them using smithy library.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #45408 done by [Mergify](https://mergify.com).

@lucian-ioan @mergify
[AWS Health] Improve error message reporting (#45408)
fe8de07 
* parse error message

* remove comment

* fix CI

* add changelog entry

(cherry picked from commit 1637c55)

# Conflicts:
#	x-pack/metricbeat/module/aws/awshealth/awshealth.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jul 19, 2025
@mergify mergify bot requested a review from a team as a code owner July 19, 2025 07:06
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 19, 2025

Cherry-pick of 1637c55 has failed:

On branch mergify/bp/9.0/pr-45408
Your branch is up to date with 'origin/9.0'.

You are currently cherry-picking commit 1637c556c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/metricbeat/module/aws/awshealth/awshealth.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the backport label Jul 19, 2025
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Jul 19, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2025
@mergify mergify bot mentioned this pull request Jul 19, 2025
Merged
6 tasks
@github-actions github-actions bot added bug Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Jul 19, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2025
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 21, 2025

This pull request has not been merged yet. Could you please review and merge it @lucian-ioan? 🙏

gizas
gizas reviewed Jul 21, 2025
View reviewed changes
CHANGELOG.next.asciidoc
@@ -41,6 +41,11 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
- Add support for Kibana status metricset in v8 format {pull}40275[40275]
- Mark system process metricsets as running if metrics are partially available {pull}40565[40565]
- Fixed a bug where `event.duration` could be missing from an event on Windows systems due to low-resolution clock. {pull}44440[44440]
- Add check for http error codes in the Metricbeat's Prometheus query submodule {pull}44493[44493]
- Sanitize error messages in Fetch method of SQL module {pull}44577[44577]
- Add NTP metricset to system module. {pull}44884[44884]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #45479 needs fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizas gizas gizas left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lucian-ioan lucian-ioan

Labels
backport bug conflicts There is a conflict in the backported pull request Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gizas @lucian-ioan