Skip to content

[8.17](backport #45408) [AWS Health] Improve error message reporting #45479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.17
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2025

Proposed commit message

Make error messages explicit by parsing them using smithy library.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #45408 done by [Mergify](https://mergify.com).

* parse error message

* remove comment

* fix CI

* add changelog entry

(cherry picked from commit 1637c55)

# Conflicts:
#	x-pack/metricbeat/module/aws/awshealth/awshealth.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jul 19, 2025
@mergify mergify bot requested a review from a team as a code owner July 19, 2025 07:05
Copy link
Contributor Author

mergify bot commented Jul 19, 2025

Cherry-pick of 1637c55 has failed:

On branch mergify/bp/8.17/pr-45408
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit 1637c556c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/metricbeat/module/aws/awshealth/awshealth.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2025
@botelastic
Copy link

botelastic bot commented Jul 19, 2025

This pull request doesn't have a Team:<team> label.

Copy link
Contributor Author

mergify bot commented Jul 21, 2025

This pull request has not been merged yet. Could you please review and merge it @lucian-ioan? 🙏

@@ -40,6 +40,24 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
- Add support for `_nodes/stats` URIs that work with legacy versions of Elasticsearch {pull}44307[44307]
- Setting period for counter cache for Prometheus remote_write at least to 60sec {pull}38553[38553]
- Remove fallback to the node limit for the `kubernetes.pod.cpu.usage.limit.pct` and `kubernetes.pod.memory.usage.limit.pct` metrics calculation
- Add support for Kibana status metricset in v8 format {pull}40275[40275]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct should be manually updated

=======
"crypto/fips140"
"errors"
>>>>>>> 1637c556c ([AWS Health] Improve error message reporting (#45408))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix merging steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants