-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.17](backport #45408) [AWS Health] Improve error message reporting #45479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.17
Are you sure you want to change the base?
Conversation
* parse error message * remove comment * fix CI * add changelog entry (cherry picked from commit 1637c55) # Conflicts: # x-pack/metricbeat/module/aws/awshealth/awshealth.go
Cherry-pick of 1637c55 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request doesn't have a |
This pull request has not been merged yet. Could you please review and merge it @lucian-ioan? 🙏 |
@@ -40,6 +40,24 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff] | |||
- Add support for `_nodes/stats` URIs that work with legacy versions of Elasticsearch {pull}44307[44307] | |||
- Setting period for counter cache for Prometheus remote_write at least to 60sec {pull}38553[38553] | |||
- Remove fallback to the node limit for the `kubernetes.pod.cpu.usage.limit.pct` and `kubernetes.pod.memory.usage.limit.pct` metrics calculation | |||
- Add support for Kibana status metricset in v8 format {pull}40275[40275] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct should be manually updated
======= | ||
"crypto/fips140" | ||
"errors" | ||
>>>>>>> 1637c556c ([AWS Health] Improve error message reporting (#45408)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix merging steps
Proposed commit message
Make error messages explicit by parsing them using smithy library.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #45408 done by [Mergify](https://mergify.com).